Skip to content

Conversation

@raoakarsha
Copy link
Contributor

@raoakarsha raoakarsha commented Jun 29, 2022

What does this PR do?

Tries to fix the PL import error in HPU CI:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/_pytest/config/__init__.py", line 1638, in parse_warning_filter
    category: Type[Warning] = _resolve_warning_category(category_)
  File "/usr/local/lib/python3.8/dist-packages/_pytest/config/__init__.py", line 1676, in _resolve_warning_category
    m = __import__(module, None, None, [klass])
ModuleNotFoundError: No module named 'pytorch_lightning'

https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=76888&view=logs&j=8a08b103-7f3c-5f4b-1889-6a795acbb007&t=5236135a-7c43-5800-935b-e902d7c2c9ea

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the ci Continuous Integration label Jun 29, 2022
- bash: |
pip install -e .[extra] -r requirements/pytorch/test.txt
pip install -e .[extra] -r requirements/pytorch/test.txt --user
Copy link
Contributor

@akihironitta akihironitta Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't followed up on recent changes in installation of PL, but let me ping @Borda just in case he has an idea 👀 I've just realised that @Borda has also been working on debugging in #13419.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihironitta @Borda Please do not review this PR. I am trying to debug the issue. Shall update once am done with testing

@akihironitta akihironitta added the accelerator: hpu (external) Habana Processing Unit label Jun 29, 2022
@raoakarsha raoakarsha marked this pull request as draft June 29, 2022 17:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: hpu (external) Habana Processing Unit ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants