Skip to content

changing tests/README.md to reflect repo structure change #13437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2022
Merged

changing tests/README.md to reflect repo structure change #13437

merged 4 commits into from
Jul 27, 2022

Conversation

@nitinramvelraj
Copy link
Contributor

@nitinramvelraj nitinramvelraj commented Jun 28, 2022 •
edited
Loading

What does this PR do?

Changing tests/README.md to reflect changes in repo structure.

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

carmocca
carmocca reviewed Jun 29, 2022
View reviewed changes
@carmocca carmocca modified the milestones: pl:1.6.x, pl:1.7 Jun 29, 2022
@carmocca carmocca added docs Documentation related community This PR is from the community labels Jun 29, 2022
Borda
Borda approved these changes Jun 29, 2022
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Jun 29, 2022
akihironitta
akihironitta approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 🚀

@nitinramvelraj
Copy link
Contributor Author

nitinramvelraj commented Jul 5, 2022

Hi, is there anything left to be done on this PR?

@carmocca carmocca enabled auto-merge (squash) July 27, 2022 09:41
@carmocca carmocca merged commit b37e466 into Lightning-AI:master Jul 27, 2022
Borda added a commit that referenced this pull request Jul 29, 2022
@nitinramvelraj @Borda @carmocca
Change tests/README.md to reflect repo structure change (#13437)
f57560d 
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit b37e466)
lexierule pushed a commit that referenced this pull request Aug 1, 2022
@nitinramvelraj @Borda
@carmocca @lexierule
Change tests/README.md to reflect repo structure change (#13437)
5cd0d52 
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
(cherry picked from commit b37e466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

+2 more reviewers

@carmocca carmocca carmocca approved these changes

@akihironitta akihironitta akihironitta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Borda Borda

Labels

community This PR is from the community docs Documentation related ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.7

Development

Successfully merging this pull request may close these issues.

5 participants

@nitinramvelraj @Borda @carmocca @akihironitta @rohitgr7