Skip to content

Make save_hyperparamters not save another class's args when LightningModule instantiated within another class's constructor #13202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Make save_hyperparamters not save another class's args when LightningModule instantiated within another class's constructor #13202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cac78ab
Resolving conflict for duplicate args
tanmoyio Jun 1, 2022
a048ca7
Merge branch 'master' of https://github.com/tanmoyio/pytorch-lightnin…
tanmoyio Jun 1, 2022
5cb31c7
unit test fixed
tanmoyio Jun 1, 2022
5098c44
Merge branch 'master' of https://github.com/Lightning-AI/lightning in…
tanmoyio Jun 18, 2022
d7a95aa
Merge branch 'master' into bug/13181_save_hyperparameters
akihironitta Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pytorch_lightning/utilities/parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def collect_init_args(
if "__class__" in local_vars:
local_args = get_init_args(frame)
# recursive update
path_args.append(local_args)
path_args.insert(0, local_args)
return collect_init_args(frame.f_back, path_args, inside=True)
if not inside:
return collect_init_args(frame.f_back, path_args, inside)
Expand Down
4 changes: 2 additions & 2 deletions tests/tests_pytorch/utilities/test_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,8 @@ def __init__(self, anyarg, childarg, anykw=42, childkw=42, **kwargs):
super().__init__(anyarg, anykw=anykw, **kwargs)

my_class = AutomaticArgsChild("test1", "test2", anykw=32, childkw=22, otherkw=123)
assert my_class.result[0] == {"anyarg": "test1", "anykw": 32, "otherkw": 123}
assert my_class.result[1] == {"anyarg": "test1", "childarg": "test2", "anykw": 32, "childkw": 22, "otherkw": 123}
assert my_class.result[0] == {"anyarg": "test1", "childarg": "test2", "anykw": 32, "childkw": 22, "otherkw": 123}
assert my_class.result[1] == {"anyarg": "test1", "anykw": 32, "otherkw": 123}


def test_attribute_dict(tmpdir):
Expand Down