Skip to content

added warnings to unimplemented methods #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2020
Merged

added warnings to unimplemented methods #1317

merged 3 commits into from
Apr 3, 2020

Conversation

@williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Mar 31, 2020

  • Return warnings for unimplemented methods.
  • remove default adam optimizer
  • keep interface as simple as PyTorch module if a user wants.

@mergify mergify bot requested a review from a team March 31, 2020 13:42
@Borda Borda added the feature Is an improvement or enhancement label Mar 31, 2020
@Borda Borda added this to the 0.7.2 milestone Mar 31, 2020
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2020

This pull request is now in conflict... :(

@jeremyjordan
Copy link
Contributor

jeremyjordan commented Mar 31, 2020

some overlap with #1199, not sure if you saw that PR

@ethanwharris
Copy link
Member

ethanwharris commented Mar 31, 2020

Potentially some overlap with #1279

@SkafteNicki SkafteNicki mentioned this pull request Apr 1, 2020
Merged
5 tasks
@williamFalcon williamFalcon changed the title added warnings and removed default optimizer added warnings to unimplemented methods Apr 2, 2020
Borda
Borda approved these changes Apr 2, 2020
View reviewed changes
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda requested review from a team, neggert and tullie April 2, 2020 23:03
@Borda Borda added the ready PRs ready to be merged label Apr 2, 2020
@Borda Borda requested a review from a team April 3, 2020 07:23
@williamFalcon williamFalcon merged commit e68ba1c into master Apr 3, 2020
@williamFalcon williamFalcon deleted the optimizer branch April 3, 2020 19:11
alexeykarnachev pushed a commit to alexeykarnachev/pytorch-lightning that referenced this pull request Apr 4, 2020
@williamFalcon @Borda
added warnings to unimplemented methods (Lightning-AI#1317)
b4a0413 
* added warnings and removed default optimizer

* opt

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <[email protected]>
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@williamFalcon @Borda @tullie
added warnings to unimplemented methods (Lightning-AI#1317)
68420c3 
* added warnings and removed default optimizer

* opt

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <[email protected]>
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@neggert neggert Awaiting requested review from neggert

@tullie tullie Awaiting requested review from tullie

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@jeremyjordan jeremyjordan Awaiting requested review from jeremyjordan

Assignees

No one assigned

Labels

feature Is an improvement or enhancement ready PRs ready to be merged

Projects

None yet

Milestone

pl:0.7.x

Development

Successfully merging this pull request may close these issues.

5 participants

@williamFalcon @jeremyjordan @ethanwharris @Borda @justusschock