Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented May 24, 2022

What does this PR do?

Fixes #13118.

Fixes bug reported in Slack

ss_2022-05-24_20-52-47

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @awaelchli

@carmocca carmocca added bug Something isn't working environment: torchelastic labels May 24, 2022
@carmocca carmocca added this to the 1.6.x milestone May 24, 2022
@carmocca carmocca self-assigned this May 24, 2022
@carmocca carmocca marked this pull request as ready for review May 24, 2022 13:18
@mergify mergify bot added the ready PRs ready to be merged label May 24, 2022
@akihironitta akihironitta enabled auto-merge (squash) May 24, 2022 23:42
@akihironitta akihironitta merged commit c5938f8 into master May 25, 2022
@akihironitta akihironitta deleted the bugfix/torchelastic-env branch May 25, 2022 10:23
@martinb-ai martinb-ai mentioned this pull request May 25, 2022
2 tasks
carmocca added a commit that referenced this pull request May 25, 2022
* Fix torchelastic detection under Mac

* CHANGELOG
carmocca added a commit that referenced this pull request May 31, 2022
* Fix torchelastic detection under Mac

* CHANGELOG
lexierule pushed a commit that referenced this pull request Jun 1, 2022
* Fix torchelastic detection under Mac

* CHANGELOG
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working environment: torchelastic ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Impossible to check whether a current process was launched using the torchelastic command on MacOS

5 participants