Skip to content

Conversation

@talregev
Copy link
Contributor

@talregev talregev commented Apr 6, 2022

Example for auto_insert_metric_name:

  • Add an example in case you have slash in metric name

What does this PR do?

Fixes #4012

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Example for auto_insert_metric_name:
- Add an example in case you have slash in metric name
@carmocca carmocca added docs Documentation related callback: model checkpoint labels Apr 7, 2022
@carmocca carmocca added this to the 1.7 milestone Apr 7, 2022
@talregev
Copy link
Contributor Author

@carmocca Why it take long time to review?

@mergify mergify bot added the ready PRs ready to be merged label Apr 14, 2022
@carmocca carmocca enabled auto-merge (squash) April 14, 2022 14:07
auto-merge was automatically disabled April 18, 2022 18:15

Head branch was pushed to by a user without write access

@talregev talregev requested a review from Borda April 18, 2022 18:15
@carmocca carmocca enabled auto-merge (squash) April 20, 2022 18:58
@carmocca carmocca merged commit c482ae3 into Lightning-AI:master Apr 21, 2022
@talregev talregev deleted the patch-2 branch April 21, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback: model checkpoint docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModelCheckpoint filename unable to use metrics that contain a slash

4 participants