Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Mar 25, 2022

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check when generating this link that it is without expiration 🐰

@mergify mergify bot added the ready PRs ready to be merged label Mar 25, 2022
@rohitgr7
Copy link
Contributor Author

pls check when generating this link that it is without expiration 🐰

I didn't generate this. Can you confirm with Will? the old one seems to be without any expiration date since it's still working.

@Borda
Copy link
Collaborator

Borda commented Mar 25, 2022

pls check when generating this link that it is without expiration rabbit

I didn't generate this. Can you confirm with Will? the old one seems to be without any expiration date since it's still working.

it is correct, just as discussed, lets create and use a permanent one :)

@akihironitta akihironitta added the docs Documentation related label Mar 26, 2022
@akihironitta
Copy link
Contributor

pls check when generating this link that it is without expiration 🐰

I remember even if it's generated without expiration, it'll be expired after a certain number of people join Slack with the link, so I guess maybe we need to have a permanent proxy link and update its redirection occasionally.

@carmocca carmocca added this to the 1.6 milestone Mar 28, 2022
@carmocca carmocca merged commit fe12bae into master Mar 28, 2022
@carmocca carmocca deleted the docs/slack_link branch March 28, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants