Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 21, 2022

What does this PR do?

by default run prune package on all requirements files to reduce issue with setting wrong file

Does your PR introduce any breaking changes? If yes, please list them.

that was our issue in past #12318 (comment), we were removing horovod from a file where it was not
now it is from all require files unless you set a specific i=one

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@mergify mergify bot added the ready PRs ready to be merged label Mar 21, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda enabled auto-merge (squash) March 21, 2022 09:01
@Borda Borda added this to the 1.6 milestone Mar 21, 2022
@Borda Borda merged commit fe940e1 into master Mar 21, 2022
@Borda Borda deleted the ci/prune_pkgs branch March 21, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants