Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Mar 15, 2022

What does this PR do?

The docs for the ModelCheckpoint argument save_last were misleading.
This PR updates the description of how the feature works.
Addresses partially #11805 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @rohitgr7 @carmocca @awaelchli @ninginthecloud @jjenniferdai

@awaelchli awaelchli added the docs Documentation related label Mar 15, 2022
@awaelchli awaelchli added this to the 1.6 milestone Mar 15, 2022
@awaelchli awaelchli marked this pull request as ready for review March 15, 2022 05:08
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot added the ready PRs ready to be merged label Mar 15, 2022
@awaelchli awaelchli enabled auto-merge (squash) March 19, 2022 04:44
@awaelchli awaelchli merged commit eda53d7 into master Mar 19, 2022
@awaelchli awaelchli deleted the docs/save-last branch March 19, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback: model checkpoint docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants