Skip to content

Conversation

@ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Feb 26, 2022

What does this PR do?

Fixes #10984

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub added deprecation Includes a deprecation hooks Related to the hooks API labels Feb 26, 2022
@ananthsub ananthsub added this to the 1.6 milestone Feb 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 26, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the has conflicts label Mar 2, 2022
@ananthsub ananthsub force-pushed the feat/depreate-lm-on-pretrain-routine-start branch from 320f659 to ce88d4e Compare March 5, 2022 05:25
@mergify mergify bot removed the has conflicts label Mar 5, 2022
@ananthsub ananthsub merged commit 9c3d6b8 into Lightning-AI:master Mar 5, 2022
@ananthsub ananthsub deleted the feat/depreate-lm-on-pretrain-routine-start branch March 5, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Includes a deprecation hooks Related to the hooks API ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] Deprecate on_pretrain_routine_start and on_pretrain_routine_end LM/callback hooks

7 participants