Skip to content

Conversation

@daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Feb 19, 2022

What does this PR do?

Fixes #11961

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the docs Documentation related label Feb 20, 2022
@awaelchli awaelchli added this to the 1.6 milestone Feb 20, 2022
@awaelchli awaelchli enabled auto-merge (squash) February 20, 2022 21:43
@mergify mergify bot added the ready PRs ready to be merged label Feb 20, 2022
@awaelchli awaelchli disabled auto-merge February 21, 2022 19:49
@awaelchli awaelchli merged commit d724465 into Lightning-AI:master Feb 21, 2022
@daniellepintz daniellepintz deleted the fix_docs branch February 21, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong documentations for on_fit_* of TrainerCallbackHookMixin

4 participants