Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Feb 12, 2022

What does this PR do?

Fixes the invalid workflow file for releasing docker images.

I was looking at some recent logs of release_docker.yml, and it turned out that the workflow hadn't run successfully for a few months since the change in #10075 with this error message:

Invalid workflow file: .github/workflows/release-docker.yml#L42
The workflow is not valid. .github/workflows/release-docker.yml (Line: 42, Col: 13): Unexpected symbol: '"3'. Located at position 26 within ...

It seems like ' has to be used within if block in GHA workflow file, which I confirmed in my toy repo here:

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@akihironitta akihironitta added bug Something isn't working ci Continuous Integration labels Feb 12, 2022
@akihironitta akihironitta added this to the 1.6 milestone Feb 12, 2022
@akihironitta
Copy link
Contributor Author

Just realised that #11819 includes this fix, so closing this PR.

@Borda Borda deleted the ci/fix_release_docker branch March 29, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant