Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 11, 2022

What does this PR do?

Refactor a legacy early stopping test.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @akihironitta @carmocca @awaelchli @rohitgr7

@mergify mergify bot added the ready PRs ready to be merged label Feb 14, 2022
@carmocca carmocca mentioned this pull request Feb 14, 2022
8 tasks
@carmocca carmocca enabled auto-merge (squash) February 17, 2022 22:10
@carmocca carmocca merged commit a0ca8d0 into master Feb 17, 2022
@carmocca carmocca deleted the tests/refactor-es-test branch February 17, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants