Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Feb 9, 2022

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@rohitgr7 rohitgr7 enabled auto-merge (squash) February 9, 2022 21:01
@rohitgr7 rohitgr7 added this to the 1.6 milestone Feb 9, 2022
@rohitgr7 rohitgr7 added the docs Documentation related label Feb 9, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #11830 (a3d787f) into master (1e36cff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11830   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         198      198           
  Lines       17321    17321           
=======================================
  Hits        15852    15852           
  Misses       1469     1469           

@rohitgr7 rohitgr7 merged commit 5e78f42 into master Feb 10, 2022
@rohitgr7 rohitgr7 deleted the chlog/post_1.5.10 branch February 10, 2022 13:10
rohitgr7 added a commit that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants