-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add Accelerator.is_available() interface requirement
#11797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
approved these changes
Feb 7, 2022
This was referenced Feb 7, 2022
tchaton
approved these changes
Feb 7, 2022
rohitgr7
reviewed
Feb 7, 2022
four4fish
approved these changes
Feb 7, 2022
12 tasks
8f704a2 to
a20c0ae
Compare
353cf79 to
8362713
Compare
946c175 to
569fb6c
Compare
rohitgr7
approved these changes
Feb 8, 2022
e2dcbfe to
9cc7c00
Compare
justusschock
approved these changes
Feb 9, 2022
rohitgr7
previously approved these changes
Feb 9, 2022
rohitgr7
reviewed
Feb 9, 2022
rohitgr7
reviewed
Feb 9, 2022
carmocca
reviewed
Feb 9, 2022
Contributor
carmocca
reviewed
Feb 9, 2022
awaelchli
approved these changes
Feb 9, 2022
12 tasks
Contributor
Author
rohitgr7
reviewed
Feb 9, 2022
rohitgr7
approved these changes
Feb 9, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accelerator: cuda
Compute Unified Device Architecture GPU
breaking change
Includes a breaking change
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
acc_cls.is_available()and determine the hardware immediately.This aims to simplify the accelerator connector logic and rewrite effort in #11448
This would move the hardcoded, duplicated assertion logic from Trainer constructor checks to a single runtime check at
trainer.fit/validate/test/predictcallsGiven discussion on this PR, we can decide where the assertion on device availability should happen. Either in the accelerator init, setup_environment, or left up to individual accelerators to decide
Fixes #11818
Does your PR introduce any breaking changes? If yes, please list them.
Yes, this now:
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃