Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jan 31, 2022

What does this PR do?

Part of #11643

Found while reviewing #11643.
The removed code snippet refers to DDPStrategy.num_processes being None, but this is never True since we set that value at the time of Trainer instantiation. This is legacy dead code and can be safely removed.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7 @kaushikb11

@awaelchli awaelchli added refactor strategy: ddp DistributedDataParallel labels Jan 31, 2022
@awaelchli awaelchli added this to the 1.6 milestone Jan 31, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 31, 2022
@awaelchli awaelchli mentioned this pull request Jan 31, 2022
12 tasks
@carmocca carmocca enabled auto-merge (squash) February 3, 2022 02:16
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #11678 (9c04996) into master (7da931d) will increase coverage by 36%.
The diff coverage is 100%.

❗ Current head 9c04996 differs from pull request most recent head 7ac8660. Consider uploading reports for the commit 7ac8660 to get more accurate results

@@            Coverage Diff            @@
##           master   #11678     +/-   ##
=========================================
+ Coverage      56%      92%    +36%     
=========================================
  Files         197      195      -2     
  Lines       17224    17124    -100     
=========================================
+ Hits         9619    15734   +6115     
+ Misses       7605     1390   -6215     

@carmocca carmocca merged commit cc43d07 into master Feb 5, 2022
@carmocca carmocca deleted the refactor/legacy-ddp branch February 5, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor strategy: ddp DistributedDataParallel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants