Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 17, 2022

What does this PR do?

Part of docs revamp #7666
This section already looks good. Couldn't find anything missing/requires an update in this one.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@rohitgr7 rohitgr7 added the docs Documentation related label Jan 17, 2022
@rohitgr7 rohitgr7 added this to the 1.6 milestone Jan 17, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review January 17, 2022 13:42
@mergify mergify bot added the ready PRs ready to be merged label Jan 17, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) January 17, 2022 17:48
@rohitgr7 rohitgr7 merged commit d50b48e into master Jan 17, 2022
@rohitgr7 rohitgr7 deleted the docs/comm_section branch January 17, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants