Skip to content

[CI] Unpin fairscale #11478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[CI] Unpin fairscale #11478

wants to merge 2 commits into from

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 14, 2022

What does this PR do?

Reverts #10200 after facebookresearch/fairscale#834 got fixed and released.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added ci Continuous Integration strategy: fairscale fsdp (removed) Fully Sharded Data Parallel strategy: fairscale sharded (removed) Sharded Data Parallel labels Jan 14, 2022
@carmocca carmocca added this to the 1.6 milestone Jan 14, 2022
@carmocca carmocca self-assigned this Jan 14, 2022
@carmocca carmocca removed the strategy: fairscale sharded (removed) Sharded Data Parallel label Jan 14, 2022
@carmocca
Copy link
Contributor Author

carmocca commented Jan 14, 2022

The cuda image build is failing due to apex, needs to be fixed first.

@carmocca carmocca mentioned this pull request Jan 21, 2022
Merged
12 tasks
@carmocca carmocca closed this Jan 21, 2022
@carmocca carmocca deleted the ci/unpin-fairscale branch January 21, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

@Borda Borda Awaiting requested review from Borda Borda will be requested when the pull request is marked ready for review Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton will be requested when the pull request is marked ready for review tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock will be requested when the pull request is marked ready for review justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris will be requested when the pull request is marked ready for review ethanwharris is a code owner

Assignees

@carmocca carmocca

Labels

ci Continuous Integration strategy: fairscale fsdp (removed) Fully Sharded Data Parallel

Projects

None yet

Milestone

pl:1.6

Development

Successfully merging this pull request may close these issues.

1 participant

@carmocca