Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jan 7, 2022

What does this PR do?

Found by @carmocca in #11217.

  • Makes sure to raise ModuleNotFoundError if rich isn't installed or supported version of it isn't installed.
  • Changes the tests so that the death tests above run regardless of rich availability.

Does your PR introduce any breaking changes? If yes, please list them.

  • raise ModuleNotFoundError instead of MisconfigurationException when rich isn't installed.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @SeanNaren @kaushikb11 @Borda

@akihironitta akihironitta added the bug Something isn't working label Jan 7, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of opening a PR.

This wasn't caught before because these tests don't really run, all jobs seem to install rich

@kaushikb11
Copy link
Contributor

Thanks @akihironitta for looking into this!

Copy link
Contributor Author

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihironitta akihironitta added this to the 1.5.x milestone Jan 7, 2022
@akihironitta akihironitta changed the title [wip] Fix inconsistent exceptions raised with no rich installed Fix inconsistent exceptions raised with no rich installed Jan 7, 2022
@akihironitta akihironitta marked this pull request as ready for review January 7, 2022 16:14
@mergify mergify bot added the ready PRs ready to be merged label Jan 7, 2022
@ananthsub ananthsub added progress bar: rich and removed ready PRs ready to be merged labels Jan 7, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 7, 2022
@carmocca carmocca enabled auto-merge (squash) January 7, 2022 17:11
@carmocca carmocca merged commit 8dc36c3 into master Jan 12, 2022
@carmocca carmocca deleted the bugfix/rich-import branch January 12, 2022 03:55
@carmocca carmocca modified the milestones: 1.5.x, 1.6 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working progress bar: rich ready PRs ready to be merged tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants