Skip to content

Conversation

@kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Dec 20, 2021

What does this PR do?

Similar to #11098

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda @SeanNaren

@kaushikb11 kaushikb11 added accelerator: ipu (removed) Intelligence Processing Unit ci Continuous Integration labels Dec 20, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review December 20, 2021 12:16
@Borda
Copy link
Collaborator

Borda commented Dec 20, 2021

yep nice improvement on stability and scalability :]
just wondering how long it may take because we had to do this trimming on purpose back then

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Requires to use RunIf(ipu=True) for all the ipu tests.

@stale stale bot added the won't fix This will not be worked on label Jan 7, 2022
@awaelchli awaelchli added this to the 1.6 milestone Jan 7, 2022
@stale stale bot removed the won't fix This will not be worked on label Jan 7, 2022
@akihironitta akihironitta self-assigned this Mar 25, 2022
@akihironitta akihironitta changed the title Collect and run all ipu tests Collect and run all IPU tests Mar 25, 2022
@Lightning-AI Lightning-AI deleted a comment from stale bot Mar 25, 2022
@mergify mergify bot added the ready PRs ready to be merged label Mar 25, 2022
@akihironitta akihironitta enabled auto-merge (squash) March 25, 2022 04:59
@Borda
Copy link
Collaborator

Borda commented Mar 25, 2022

just for the record :)
image

@akihironitta akihironitta merged commit 089fcb9 into master Mar 25, 2022
@akihironitta akihironitta deleted the ci/ipu_tests branch March 25, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: ipu (removed) Intelligence Processing Unit ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants