Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 19, 2021

What does this PR do?

Follow up to #11137
Fixes #10987

The two TTP methods pre_dispatch and setup were merged in #11137. Accordingly, the related property restore_checkpoint_after_pre_dispatch should now be renamed to restore_checkpoint_after_setup.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @awaelchli @akihironitta @SeanNaren

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton marked this pull request as ready for review December 20, 2021 16:41
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Dec 20, 2021
@carmocca carmocca enabled auto-merge (squash) December 20, 2021 16:45
@carmocca carmocca merged commit 08e661f into master Dec 20, 2021
@carmocca carmocca deleted the refactor/restore-after-predispatch branch December 20, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] Revisit/merge/deprecate pre_dispatch, dispatch, post_dispatch and run_stage functions from strategies and trainer

4 participants