-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Simplify TPUSpawn rank management #11163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ba27170 to
2ed5810
Compare
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a breaking change for everyone who was accessing them through the Strategy.
@awaelchli Are we removing these attributes without any deprecation? To me, it looks quite inconsistent that these are removed instantly in v1.6 while SingleTPUPlugin will be removed in v1.8.
Yes. I will add the deprecation if reviewers specifically request it.
Yes it is inconsistent because not all changes we want to do for 1.6 can be made backward compatible or deprecation-friendly. |
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Waiting for TPU CI to be reactivated |
What does this PR do?
Fixes #10986
The attributes
tpu_local_core_rankandtpu_global_core_ranktoday behave identically to thelocal_rankandglobal_rankattributes. They are no longer needed.It is a breaking change for everyone who was accessing them through the Strategy.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @Borda @carmocca @JackCaoG @Liyang90 @gkroiz @justusschock @awaelchli @kaushikb11 @rohitgr7 @akihironitta