Skip to content

Fix signal teardown outside main thread #11124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Fix signal teardown outside main thread #11124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytorch_lightning/trainer/connectors/signal_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def teardown(self) -> None:
"""Restores the signals that were previsouly configured before :class:`SignalConnector` replaced them."""
for signum, handler in self._original_handlers.items():
if handler is not None:
signal.signal(signum, handler) # type: ignore[arg-type]
self._register_signal(signum, handler)
self._original_handlers = {}

@staticmethod
Expand Down