Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 24, 2021

What does this PR do?

Follow up to #10163
Requested by #10682
Part of #7037

cc @Borda @justusschock @kaushikb11 @awaelchli @akihironitta @ananthsub @daniellepintz

What does this PR do?

Fixes

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli added docs Documentation related plugin labels Nov 25, 2021
@awaelchli awaelchli added this to the 1.6 milestone Nov 25, 2021
@awaelchli awaelchli marked this pull request as ready for review November 25, 2021 01:51
@mergify mergify bot added the ready PRs ready to be merged label Nov 25, 2021
@mergify mergify bot removed the has conflicts label Nov 25, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kaushikb11 kaushikb11 enabled auto-merge (squash) November 25, 2021 18:13
@kaushikb11 kaushikb11 merged commit 038c151 into master Nov 26, 2021
@kaushikb11 kaushikb11 deleted the refactor/plugins-typing branch November 26, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related plugin ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants