Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 23, 2021

What does this PR do?

Addresses comment
We have an enum that covers several precision types such as 16 bit, "bf16", "mixed", etc.
This PR makes sure we use the enum fields instead of the raw values across the code base.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @awaelchli @akihironitta @carmocca

@awaelchli awaelchli added precision: amp Automatic Mixed Precision refactor labels Nov 23, 2021
@awaelchli awaelchli added this to the 1.6 milestone Nov 23, 2021
@awaelchli awaelchli marked this pull request as ready for review November 23, 2021 14:16
@justusschock justusschock enabled auto-merge (squash) November 23, 2021 15:22
@mergify mergify bot added the ready PRs ready to be merged label Nov 23, 2021
@mergify mergify bot requested a review from a team November 23, 2021 15:22
@justusschock justusschock merged commit 89d0064 into master Nov 23, 2021
@justusschock justusschock deleted the refactor/use-precision-type branch November 23, 2021 17:23
rohitgr7 pushed a commit that referenced this pull request Nov 24, 2021
* use precision type

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
rohitgr7 pushed a commit that referenced this pull request Nov 24, 2021
* use precision type

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

precision: amp Automatic Mixed Precision ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants