Skip to content

Tune cc-bot settings #10544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2021
Merged

Tune cc-bot settings #10544

merged 3 commits into from
Nov 16, 2021

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 15, 2021 •
edited
Loading

What does this PR do?

  • Makes sure the bot runs on contributor PRs.
  • Do not run draft PRs
  • Run when marked as ready to review.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca

@carmocca carmocca added bug Something isn't working ci Continuous Integration labels Nov 15, 2021
@carmocca carmocca added this to the 1.6 milestone Nov 15, 2021
@carmocca carmocca self-assigned this Nov 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca changed the title Allow cc-bot to run on contributor PRs Tune cc-bot settings Nov 16, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca force-pushed the ci/probot-auto-cc-fix branch from 6e85f58 to 8d96b9a Compare November 16, 2021 14:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mergify mergify bot added the ready PRs ready to be merged label Nov 16, 2021
@mergify mergify bot requested a review from a team November 16, 2021 14:30
tchaton
tchaton approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca enabled auto-merge (squash) November 16, 2021 14:33
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca added working as intended Working as intended and removed working as intended Working as intended labels Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #10544 (66bd400) into master (e98ace3) will increase coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #10544    +/-   ##
========================================
+ Coverage      88%      92%    +4%     
========================================
  Files         178      178            
  Lines       16243    16243            
========================================
+ Hits        14274    14904   +630     
+ Misses       1969     1339   -630

@carmocca carmocca merged commit 247f5aa into master Nov 16, 2021
@carmocca carmocca deleted the ci/probot-auto-cc-fix branch November 16, 2021 18:23
@akihironitta
Copy link
Contributor

akihironitta commented Nov 17, 2021

@carmocca Seems like the bot doesn't CC in new issues (labeled refactor), e.g. #10576. Any idea why it's not working?

@carmocca
Copy link
Contributor Author

carmocca commented Nov 17, 2021

Thank you for asking! I was just looking at it. Turns out github actions don't allow double quotes. Opening a PR

@carmocca carmocca mentioned this pull request Nov 17, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@Borda Borda Awaiting requested review from Borda

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@akihironitta akihironitta akihironitta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

bug Something isn't working ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.6

Development

Successfully merging this pull request may close these issues.

5 participants

@carmocca @akihironitta @awaelchli @tchaton @justusschock