Skip to content

Conversation

@ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Nov 13, 2021

What does this PR do?

These loop examples no longer work after the Accelerator API cleanup following the v1.5 release (#10403).
This is a followup to #10312.

We at Meta detected this when upgrading our version of Lightning used. Pyre immediately caught that these methods didn't exist on the base Accelerator object.

Is there no CI that runs the examples? What ensures these loop examples don't break with other API changes?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub added the bug Something isn't working label Nov 13, 2021
@ananthsub ananthsub added this to the 1.6 milestone Nov 13, 2021
@mergify mergify bot added the ready PRs ready to be merged label Nov 13, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) November 14, 2021 19:49
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #10514 (ce608de) into master (6dfcb6a) will increase coverage by 1%.
The diff coverage is n/a.

❗ Current head ce608de differs from pull request most recent head d9d7563. Consider uploading reports for the commit d9d7563 to get more accurate results

@@           Coverage Diff            @@
##           master   #10514    +/-   ##
========================================
+ Coverage      88%      89%    +1%     
========================================
  Files         178      179     +1     
  Lines       16243    16273    +30     
========================================
+ Hits        14277    14418   +141     
+ Misses       1966     1855   -111     

@ananthsub ananthsub force-pushed the fix/loop-examples-training-type branch from ce608de to d9d7563 Compare November 16, 2021 05:02
@rohitgr7 rohitgr7 merged commit 98de69b into Lightning-AI:master Nov 16, 2021
@ananthsub ananthsub deleted the fix/loop-examples-training-type branch November 16, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working example ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants