Skip to content

Enable distributed training with CombinedDataLoader and max_size_cycle #10374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 9, 2021
Merged

Enable distributed training with CombinedDataLoader and max_size_cycle #10374

merged 16 commits into from
Nov 9, 2021

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 5, 2021 •
edited
Loading

What does this PR do?

This PR adds support for CombinedDataLoader with max_size_cycle and distributed training.
The current prepare_dataloader wasn't injected a DistributedSampler within the CycleIterator loader.

Fixes #10373

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Nov 5, 2021
@tchaton tchaton added this to the 1.5.x milestone Nov 5, 2021
@tchaton tchaton added the bug Something isn't working label Nov 5, 2021
tchaton
tchaton commented Nov 5, 2021
View reviewed changes
@tchaton tchaton mentioned this pull request Nov 5, 2021
Closed
@mergify mergify bot added the has conflicts label Nov 8, 2021
awaelchli
awaelchli reviewed Nov 8, 2021
View reviewed changes
@mergify mergify bot removed the has conflicts label Nov 9, 2021
@tchaton tchaton requested a review from awaelchli November 9, 2021 10:10
awaelchli
awaelchli approved these changes Nov 9, 2021
View reviewed changes
@awaelchli awaelchli added data handling Generic data-related topic distributed Generic distributed-related topic labels Nov 9, 2021
@awaelchli awaelchli mentioned this pull request Nov 9, 2021
Merged
11 tasks
@mergify mergify bot added the has conflicts label Nov 9, 2021
@mergify mergify bot removed the has conflicts label Nov 9, 2021
carmocca
carmocca reviewed Nov 9, 2021
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an esoteric part of the codebase

@tchaton tchaton requested a review from carmocca November 9, 2021 14:55
@mergify mergify bot added the ready PRs ready to be merged label Nov 9, 2021
carmocca
carmocca approved these changes Nov 9, 2021
View reviewed changes
@justusschock justusschock enabled auto-merge (squash) November 9, 2021 17:09
@justusschock justusschock merged commit 8d810d6 into master Nov 9, 2021
@justusschock justusschock deleted the bugfix_10373 branch November 9, 2021 20:06
awaelchli added a commit that referenced this pull request Nov 10, 2021
@awaelchli @carmocca @tchaton
Enable distributed training with CombinedDataLoader and max_size_cycle (
e42072c 
#10374)

Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Thomas Chaton <[email protected]>
lexierule pushed a commit that referenced this pull request Nov 16, 2021
@awaelchli @carmocca
@tchaton @lexierule
Enable distributed training with CombinedDataLoader and max_size_cycle (
ab44b81 
#10374)

Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Thomas Chaton <[email protected]>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justusschock justusschock justusschock approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tchaton tchaton

Labels

bug Something isn't working data handling Generic data-related topic distributed Generic distributed-related topic ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.5.x

Development

Successfully merging this pull request may close these issues.

CombinedLoader does not work in DDP when using max_size_cyle option

5 participants

@tchaton @awaelchli @carmocca @justusschock