Skip to content

Conversation

@Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Nov 5, 2021

What does this PR do?

Fixes #10602

Adds best model checkpoint uploading to NeptuneLogger.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added bug Something isn't working logger Related to the Loggers labels Nov 9, 2021
@awaelchli
Copy link
Contributor

Seems our codeowners github trigger did not work. They were not requested for review.
https://github.com/PyTorchLightning/pytorch-lightning/blob/edbf27430d02b59da717a870d98154f3dbea8ff1/.github/CODEOWNERS#L29

Pinging them manually for now:
@shnela @HubertJaworski @pkasprzyk @pitercl @Raalsky @aniezurawski @kamil-kaczmarek
Could one of you have a quick look? Thx

@awaelchli awaelchli added feature Is an improvement or enhancement bug Something isn't working and removed bug Something isn't working feature Is an improvement or enhancement labels Nov 9, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Nov 9, 2021
@kamil-kaczmarek
Copy link

@awaelchli
approved.

@mergify mergify bot added the has conflicts label Nov 9, 2021
@Raalsky Raalsky changed the title [Draft] Fixed uploading best model checkpoint in NeptuneLogger Fixed uploading best model checkpoint in NeptuneLogger Nov 9, 2021
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind update the chlog since 1.5.1 has been released?

@mergify mergify bot added the ready PRs ready to be merged label Nov 18, 2021
@carmocca carmocca removed the logger Related to the Loggers label Nov 22, 2021
@awaelchli
Copy link
Contributor

awaelchli commented Nov 27, 2021

The hanging tests were fixed on master. I tried to update the branch but don't have write access to push the changes. Could you please do it so we can merge the fix?

@mergify mergify bot removed the has conflicts label Nov 29, 2021
@mergify mergify bot removed the has conflicts label Dec 1, 2021
@Raalsky
Copy link
Contributor Author

Raalsky commented Dec 1, 2021

@awaelchli Is there anything should I take care of?

@awaelchli awaelchli enabled auto-merge (squash) December 1, 2021 13:35
@awaelchli
Copy link
Contributor

Nope, thanks for the reminder. Will check back once tests have run

@awaelchli awaelchli self-assigned this Dec 1, 2021
@awaelchli awaelchli merged commit c647841 into Lightning-AI:master Dec 1, 2021
@Raalsky Raalsky deleted the dev/checkpoints branch December 1, 2021 14:32
@awaelchli
Copy link
Contributor

Thanks @kamil-kaczmarek , this fix will be included next week in the bugfix release 1.5.5.

@kamil-kaczmarek
Copy link

Great thanks, kudos to @Raalsky for leading this bug fix 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working logger: neptune ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Neptune Logger assumes unix-style filepath for model checkpoint

8 participants