Skip to content

Conversation

@awaelchli
Copy link
Contributor

What does this PR do?

Fixes an issue with yielding in the iterator if device=None (no automatic device placement).
The test on master raises StopIteration on the first batch.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli added bug Something isn't working fabric lightning.fabric.Fabric labels Nov 2, 2021
@awaelchli awaelchli added this to the v1.5 milestone Nov 2, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added the ready PRs ready to be merged label Nov 2, 2021
@awaelchli awaelchli added the priority: 0 High priority task label Nov 2, 2021
@justusschock justusschock enabled auto-merge (squash) November 2, 2021 10:40
@justusschock justusschock merged commit 373c32e into master Nov 2, 2021
@justusschock justusschock deleted the bugfix/lite-iterator branch November 2, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fabric lightning.fabric.Fabric priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants