Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 1, 2021

What does this PR do?

Follow up to #10279
Related: #10329

Adds small improvements around the init wrapper in Lite.

  • Minimal docs
  • Clearer variable names
  • Separation of tests

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @awaelchli @akihironitta @carmocca

@awaelchli awaelchli added fabric lightning.fabric.Fabric refactor labels Nov 1, 2021
@awaelchli awaelchli added this to the v1.6 milestone Nov 1, 2021
@awaelchli awaelchli mentioned this pull request Nov 2, 2021
23 tasks
@carmocca
Copy link
Contributor

@awaelchli do you want to land this before we move this code to Lightning?

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 23, 2021
@awaelchli awaelchli enabled auto-merge (squash) November 23, 2021 14:18
@awaelchli awaelchli merged commit dca1776 into master Nov 23, 2021
@awaelchli awaelchli deleted the feature/lite-dataloader branch November 23, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants