Skip to content

Conversation

@marcm-ml
Copy link
Contributor

@marcm-ml marcm-ml commented Oct 28, 2021

Advise for disabling warning message for dataloaders with intentional low workers

What does this PR do?

Closes #10182 by adding recommendation when users specifically set num_workers=0. User are invited to filter out the low worker UserWarning in https://github.com/PyTorchLightning/pytorch-lightning/blob/c33df2639f19d49c5e7520294e3221efe402d684/pytorch_lightning/trainer/data_loading.py#L109-L115

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Advise for disabling warning message for dataloaders with intentional low workers
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@carmocca carmocca added this to the v1.6 milestone Oct 28, 2021
@carmocca carmocca self-assigned this Oct 28, 2021
@carmocca carmocca added the docs Documentation related label Oct 28, 2021
@carmocca carmocca removed their assignment Oct 29, 2021
@mergify mergify bot added the ready PRs ready to be merged label Oct 29, 2021
@tchaton tchaton merged commit ff2d7e8 into Lightning-AI:master Oct 29, 2021
@marcm-ml marcm-ml deleted the docs/speed/advise-num-worker branch October 29, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable UserWarning for DataLoaders with num_workers=0

5 participants