-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Docs: fix mistakes in New Project docs #10137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
|
Thanks @rohitgr7, your changes look good to me. |
Codecov Report
@@ Coverage Diff @@
## master #10137 +/- ##
========================================
- Coverage 92% 89% -4%
========================================
Files 182 182
Lines 16111 16149 +38
========================================
- Hits 14894 14323 -571
- Misses 1217 1826 +609 |
awaelchli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
|
Congrats @adamjstewart on your fist contribution! Looking forward to more :) |
What does this PR do?
This PR fixes a number of typos/mistakes I noticed while reading through the New Project docs.
Does your PR introduce any breaking changes? If yes, please list them.
Nope
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃