Skip to content

Conversation

@adamjstewart
Copy link
Contributor

What does this PR do?

This PR fixes a number of typos/mistakes I noticed while reading through the New Project docs.

Does your PR introduce any breaking changes? If yes, please list them.

Nope

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@adamjstewart
Copy link
Contributor Author

Thanks @rohitgr7, your changes look good to me.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #10137 (9059502) into master (c9bc10c) will decrease coverage by 4%.
The diff coverage is n/a.

❗ Current head 9059502 differs from pull request most recent head 301a1bf. Consider uploading reports for the commit 301a1bf to get more accurate results

@@           Coverage Diff            @@
##           master   #10137    +/-   ##
========================================
- Coverage      92%      89%    -4%     
========================================
  Files         182      182            
  Lines       16111    16149    +38     
========================================
- Hits        14894    14323   -571     
- Misses       1217     1826   +609     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@awaelchli awaelchli added the docs Documentation related label Oct 25, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 25, 2021
@mergify mergify bot added the ready PRs ready to be merged label Oct 25, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rohitgr7 rohitgr7 enabled auto-merge (squash) October 26, 2021 14:20
@kaushikb11
Copy link
Contributor

Congrats @adamjstewart on your fist contribution! Looking forward to more :)

@rohitgr7 rohitgr7 merged commit b8ac176 into Lightning-AI:master Oct 28, 2021
@adamjstewart adamjstewart deleted the docs/new-project branch October 28, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants