Skip to content

Some minor CI cleanup #10088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 26, 2021
Merged

Some minor CI cleanup #10088

merged 9 commits into from
Oct 26, 2021

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Oct 22, 2021 •
edited
Loading

What does this PR do?

  • Use Python 3.9 for the CI jobs
  • Run only one "basic testing" job. This should is enough to catch any extra imports.

Part of #10075

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the ci Continuous Integration label Oct 22, 2021
@carmocca carmocca added this to the v1.5 milestone Oct 22, 2021
@carmocca carmocca self-assigned this Oct 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

carmocca
carmocca commented Oct 22, 2021
View reviewed changes
Borda
Borda reviewed Oct 22, 2021
View reviewed changes
Borda
Borda reviewed Oct 22, 2021
View reviewed changes
akihironitta
akihironitta reviewed Oct 23, 2021
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Oct 23, 2021
@carmocca carmocca enabled auto-merge (squash) October 26, 2021 01:41
tchaton
tchaton approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit a0e45dc into master Oct 26, 2021
@carmocca carmocca deleted the ci/cleanup branch October 26, 2021 11:58
@carmocca carmocca mentioned this pull request Oct 26, 2021
Closed
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
@carmocca @ninginthecloud
Some minor CI cleanup (Lightning-AI#10088)
baa43f6
@carmocca carmocca mentioned this pull request Oct 27, 2021
Merged
6 tasks
@awaelchli awaelchli mentioned this pull request Nov 24, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+2 more reviewers

@daniellepintz daniellepintz daniellepintz left review comments

@akihironitta akihironitta akihironitta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.5

Development

Successfully merging this pull request may close these issues.

5 participants

@carmocca @Borda @tchaton @akihironitta @daniellepintz