Skip to content

Conversation

@rohitgr7
Copy link
Contributor

What does this PR do?

See title

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added the deprecation Includes a deprecation label Oct 21, 2021
@rohitgr7 rohitgr7 added this to the v1.5 milestone Oct 21, 2021
@rohitgr7 rohitgr7 self-assigned this Oct 21, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review October 21, 2021 10:32
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@rohitgr7 rohitgr7 requested a review from carmocca October 21, 2021 13:49
@mergify mergify bot added the ready PRs ready to be merged label Oct 21, 2021
@tchaton tchaton enabled auto-merge (squash) October 21, 2021 20:17
@rohitgr7 rohitgr7 disabled auto-merge October 21, 2021 21:14
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 21, 2021 21:14
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #10066 (c302980) into master (dbe1662) will increase coverage by 4%.
The diff coverage is 100%.

❗ Current head c302980 differs from pull request most recent head a565893. Consider uploading reports for the commit a565893 to get more accurate results

@@            Coverage Diff            @@
##           master   #10066     +/-   ##
=========================================
+ Coverage      89%      93%     +4%     
=========================================
  Files         180      182      +2     
  Lines       16146    16944    +798     
=========================================
+ Hits        14317    15745   +1428     
+ Misses       1829     1199    -630     

@mergify mergify bot removed the has conflicts label Oct 25, 2021
@rohitgr7 rohitgr7 disabled auto-merge October 26, 2021 21:46
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 26, 2021 21:47
@rohitgr7 rohitgr7 merged commit 9af1dd7 into master Oct 28, 2021
@rohitgr7 rohitgr7 deleted the dep/lr_sch_names branch October 28, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Includes a deprecation ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants