Skip to content

Conversation

@rohitgr7
Copy link
Contributor

What does this PR do?

Fixes #10024

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added this to the v1.5 milestone Oct 20, 2021
@rohitgr7 rohitgr7 added the bug Something isn't working label Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #10044 (48d9678) into master (6701526) will decrease coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10044    +/-   ##
========================================
- Coverage      93%      92%    -0%     
========================================
  Files         180      180            
  Lines       15895    16381   +486     
========================================
+ Hits        14726    15125   +399     
- Misses       1169     1256    +87     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat !

@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2021
@rohitgr7 rohitgr7 merged commit 1599c77 into master Oct 20, 2021
@rohitgr7 rohitgr7 deleted the bugfix/lrm_opt_mp branch October 20, 2021 16:43
awaelchli added a commit that referenced this pull request Oct 22, 2021
…optimizer with no scheduler (#10044)"

This reverts commit 1599c77.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LearningRateMonitor KeyError with multiple parameter groups and no LR scheduler

5 participants