Skip to content

Conversation

@kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Oct 20, 2021

What does this PR do?

Follow up to #10000

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 marked this pull request as ready for review October 20, 2021 10:28
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@kaushikb11 kaushikb11 added the docs Documentation related label Oct 20, 2021
@kaushikb11 kaushikb11 added this to the v1.5 milestone Oct 20, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we indicate training type plugin will be renamed Strategy for v1.6 ?

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #10042 (6e8c162) into master (f0e6f1b) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10042   +/-   ##
=======================================
- Coverage      93%      93%   -0%     
=======================================
  Files         180      180           
  Lines       15900    15892    -8     
=======================================
- Hits        14731    14722    -9     
- Misses       1169     1170    +1     

@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2021
@kaushikb11 kaushikb11 merged commit 4f19a4d into master Oct 20, 2021
@kaushikb11 kaushikb11 deleted the trainer_docs/strategy branch October 20, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants