Skip to content

Conversation

@kaushikb11
Copy link
Contributor

What does this PR do?

Follow up to #9994

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added refactor design Includes a design discussion labels Oct 20, 2021
@kaushikb11 kaushikb11 added this to the v1.5 milestone Oct 20, 2021
@kaushikb11
Copy link
Contributor Author

@awaelchli Follow up to #9994

@mergify mergify bot added the ready PRs ready to be merged label Oct 21, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) October 21, 2021 13:51
@kaushikb11 kaushikb11 force-pushed the tpu_spawn/_setup_model branch from b138202 to 1026949 Compare October 22, 2021 07:51
@kaushikb11 kaushikb11 force-pushed the tpu_spawn/_setup_model branch from 9ab7a01 to 3a2d928 Compare October 25, 2021 08:42
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #10039 (3a2d928) into master (ed98026) will decrease coverage by 0%.
The diff coverage is 67%.

@@           Coverage Diff           @@
##           master   #10039   +/-   ##
=======================================
- Coverage      92%      92%   -0%     
=======================================
  Files         182      182           
  Lines       16111    16114    +3     
=======================================
+ Hits        14894    14896    +2     
- Misses       1217     1218    +1     

@kaushikb11 kaushikb11 merged commit 64fc0d4 into master Oct 25, 2021
@kaushikb11 kaushikb11 deleted the tpu_spawn/_setup_model branch October 25, 2021 11:44
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Includes a design discussion ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants