Skip to content

Update optimizer_step methods in accelerator and plugins #10023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Oct 20, 2021
Merged

Update optimizer_step methods in accelerator and plugins #10023

merged 33 commits into from
Oct 20, 2021

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 19, 2021 •
edited by carmocca
Loading

What does this PR do?

Part of #9987

Updates the optimizer_step, pre_optimizer_step and run_optimizer_step methods on the accelerator, TTP, and PP.
The changes are mainly:

  • instance check against LightningModule
  • update all typehints (checked and constrained by mypy)

Does your PR introduce any breaking changes? If yes, please list them.

No. Typehints were updated, no other changes involve public interface.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added design Includes a design discussion refactor labels Oct 19, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 19, 2021
four4fish
four4fish reviewed Oct 20, 2021
View reviewed changes
awaelchli
awaelchli commented Oct 20, 2021
View reviewed changes
@awaelchli awaelchli force-pushed the lightning-lite/refactors/optimizer-step branch from 5c685ed to 18b09bc Compare October 20, 2021 04:01
@awaelchli awaelchli changed the title update optimizer_step methods in accelerator and plugins Update optimizer_step methods in accelerator and plugins Oct 20, 2021
awaelchli
awaelchli commented Oct 20, 2021
View reviewed changes
@awaelchli awaelchli marked this pull request as ready for review October 20, 2021 04:49
@awaelchli awaelchli changed the base branch from master to refactor/constain-step-logic October 20, 2021 13:54
@mergify mergify bot removed the has conflicts label Oct 20, 2021
@mergify mergify bot removed the has conflicts label Oct 20, 2021
carmocca
carmocca reviewed Oct 20, 2021
View reviewed changes
carmocca
carmocca reviewed Oct 20, 2021
View reviewed changes
rohitgr7
rohitgr7 approved these changes Oct 20, 2021
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2021
Base automatically changed from refactor/constain-step-logic to master October 20, 2021 15:43
@mergify mergify bot removed the has conflicts label Oct 20, 2021
@awaelchli awaelchli enabled auto-merge (squash) October 20, 2021 15:53
@awaelchli awaelchli merged commit d419028 into master Oct 20, 2021
@awaelchli awaelchli deleted the lightning-lite/refactors/optimizer-step branch October 20, 2021 20:36
@awaelchli awaelchli mentioned this pull request Oct 22, 2021
Merged
23 tasks
awaelchli added a commit that referenced this pull request Oct 22, 2021
@awaelchli
Revert "Update optimizer_step methods in accelerator and plugins (#…
e0b6e16 
…10023)"

This reverts commit d419028.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

+3 more reviewers

@four4fish four4fish four4fish left review comments

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

design Includes a design discussion ready PRs ready to be merged refactor

Projects

None yet

Milestone

pl:1.5

Development

Successfully merging this pull request may close these issues.

6 participants

@awaelchli @Borda @carmocca @tchaton @rohitgr7 @four4fish