Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 19, 2021

What does this PR do?

Part of #9987
Follow up to #10018

Adds the spawn method also to the tpu plugin and refactors existing usages of xmp.spawn to use the new method.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added design Includes a design discussion refactor labels Oct 19, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 19, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli marked this pull request as ready for review October 19, 2021 16:05
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #10022 (f9a4db9) into master (854bdc0) will decrease coverage by 4%.
The diff coverage is 46%.

@@           Coverage Diff            @@
##           master   #10022    +/-   ##
========================================
- Coverage      93%      89%    -4%     
========================================
  Files         179      180     +1     
  Lines       15842    15872    +30     
========================================
- Hits        14658    14077   -581     
- Misses       1184     1795   +611     

@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2021
@awaelchli awaelchli enabled auto-merge (squash) October 19, 2021 22:37
@awaelchli awaelchli merged commit e0c83ee into master Oct 19, 2021
@awaelchli awaelchli deleted the lightning-lite/refactors/tpu-spawn branch October 19, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Includes a design discussion ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants