Skip to content

Conversation

@rohitgr7
Copy link
Contributor

What does this PR do?

Follow up: #9246
Remove deprecated distributed backend.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added this to the v1.5 milestone Oct 19, 2021
@rohitgr7 rohitgr7 added the design Includes a design discussion label Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #10017 (328f9e5) into master (8f14e77) will decrease coverage by 0%.
The diff coverage is 100%.

❗ Current head 328f9e5 differs from pull request most recent head c26ae88. Consider uploading reports for the commit c26ae88 to get more accurate results

@@           Coverage Diff           @@
##           master   #10017   +/-   ##
=======================================
- Coverage      93%      93%   -0%     
=======================================
  Files         179      179           
  Lines       15810    15812    +2     
=======================================
- Hits        14635    14634    -1     
- Misses       1175     1178    +3     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 19, 2021 13:23
@rohitgr7 rohitgr7 merged commit 0aa220b into master Oct 19, 2021
@rohitgr7 rohitgr7 deleted the remove/distributed_backend branch October 19, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Includes a design discussion ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants