Skip to content

Conversation

@awaelchli
Copy link
Contributor

What does this PR do?

Part of #9987

Adds a _run_backward protected method.
This method is supposed to run backward independently of LightningModule.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added design Includes a design discussion refactor labels Oct 19, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 19, 2021
@awaelchli awaelchli marked this pull request as ready for review October 19, 2021 08:55
@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2021
@mergify mergify bot requested a review from a team October 19, 2021 09:07
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli enabled auto-merge (squash) October 19, 2021 09:43
@awaelchli awaelchli merged commit 321502f into master Oct 19, 2021
@awaelchli awaelchli deleted the lightning-lite/refactors/run-backward branch October 19, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Includes a design discussion ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants