-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Closed
Labels
featureIs an improvement or enhancementIs an improvement or enhancementloggingRelated to the `LoggerConnector` and `log()`Related to the `LoggerConnector` and `log()`
Milestone
Description
🚀 Feature
- Logger connector read-only properties: https://github.com/PyTorchLightning/pytorch-lightning/pull/7882/files#r647359370
- test
fx_validatorfor all functions: https://github.com/PyTorchLightning/pytorch-lightning/blob/764d2c775e2f3568975a60e94520bca8a42b2490/pytorch_lightning/trainer/connectors/logger_connector/fx_validator.py#L83. Always usetrainer.call_hook#8498 - Refactor logging tests - they are currently scattered over several files.
- Rely on
Metricto sync. We gather+reduce together (per training type) whereastorchmetricsdoes it separately. Would also need to injectis_tpu_distributed()logic. https://github.com/PyTorchLightning/pytorch-lightning/blob/764d2c775e2f3568975a60e94520bca8a42b2490/pytorch_lightning/trainer/connectors/logger_connector/result_new.py#L176-L193
Fault Tolerant Logging
- Serialization: bab742e 37e7589
- Add
load_from_state_dictto ResultCollection - Design loop state save/load hierarchy. WIP in 189f0ad. Intended structure:
trainer
loops:
fit_loop:
epoch_loop:
batch_loop:
validation_loop:
...
validate_loop:
...
test_loop:
...
------
and each loop has:
a_loop:
progress
results
- Include the loops state in the checkpoint
Metadata
Metadata
Assignees
Labels
featureIs an improvement or enhancementIs an improvement or enhancementloggingRelated to the `LoggerConnector` and `log()`Related to the `LoggerConnector` and `log()`