-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Closed
Labels
discussionIn a discussion stageIn a discussion stagegood first issueGood for newcomersGood for newcomershelp wantedOpen to be worked onOpen to be worked onrefactor
Milestone
Description
🚀 Feature
it may be nice to have some general calls over our enums such as Distributed mentioned by @carmocca in #5300 (comment)
Any logic to compare different DistributedTypes should be encapsulated by the enum itself.
- PoC: Accelerator refactor #5743 (comment)
- PoC: Accelerator refactor #5743 (comment)
- Ensure accelerator is valid if running interactively #5970 (comment)
Motivation
easier handling some cumulative behaviours, such is_ddp which cover DDP and DDP_SPAWN
Pitch
class DistributedType(LightningEnum):
DP = 'dp'
...
def is_distributed(self):
return self in (DistributedType.DDP, DistributedType.DDP_SPAWN, DistributedType.DDP2)Metadata
Metadata
Assignees
Labels
discussionIn a discussion stageIn a discussion stagegood first issueGood for newcomersGood for newcomershelp wantedOpen to be worked onOpen to be worked onrefactor