pre-commit failures

[arnaudgelas]

Hi,
I noticed in the git repository pre-commit configuration files. So I could not resist running pre-commit run --all-files

• Most of files are being modified.
  • I would advise developers to set it up properly (could be part of contribution.md), or to get rid of it
  • I would also advise adding checks in the CI
• mypy hook is failing, see errors below.
  • Most likely CI mypy configuration is different from pre-commit. I would advise either to make them match, or remove mypy step as pre-commit hook.

mypy.....................................................................Failed

• hook id: mypy
• exit code: 1

docs/source/conf.py:30: error: Module has no attribute "LIGHTNING_SETUP" [attr-defined]
docs/source/conf.py:278: error: Function is missing a type annotation [no-untyped-def]
docs/source/conf.py:296: error: Function is missing a type annotation [no-untyped-def]
setup.py:27: error: Name 'builtins' already defined (by an import) [no-redef]
setup.py:32: error: Module has no attribute "LIGHTNING_SETUP" [attr-defined]
tests/models/data/horovod/train_default_model.py:32: error: Item "None" of "Optional[str]" has no attribute "split" [union-attr]
tests/models/data/horovod/train_default_model.py:47: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:31: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:32: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:33: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:50: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:62: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:72: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:108: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:121: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:124: error: Function is missing a return type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:131: error: Function is missing a return type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:131: note: Use "-> None" if function does not return a value
tests/trainer/logging/test_logger_connector.py:137: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:158: error: Function is missing a return type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:166: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:203: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:214: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:224: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:228: error: Function is missing a return type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:228: note: Use "-> None" if function does not return a value
tests/trainer/logging/test_logger_connector.py:232: error: Function is missing a return type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:269: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:371: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:377: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:382: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:386: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:390: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:395: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:399: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:404: error: Function is missing a type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:408: error: Function is missing a return type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:411: error: Function is missing a return type annotation [no-untyped-def]
tests/trainer/logging/test_logger_connector.py:414: error: Function is missing a return type annotation [no-untyped-def]
Found 37 errors in 4 files (checked 352 source files)

[github-actions]

Hi! thanks for your contribution!, great first issue!