-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Closed
Labels
deprecationIncludes a deprecationIncludes a deprecationgood first issueGood for newcomersGood for newcomershelp wantedOpen to be worked onOpen to be worked onhooksRelated to the hooks APIRelated to the hooks APIpriority: 0High priority taskHigh priority taskrefactor
Description
Proposed refactor
Deprecate on_before_accelerator_backend_setup hook in v1.6 for removal in v1.8. Redirect users to the setup hook.
https://github.com/PyTorchLightning/pytorch-lightning/blob/5ad5ba54c0c477546d21daf75ac7b4748d7963a7/pytorch_lightning/callbacks/base.py#L63-L65
Motivation
I only see two external uses of this hook and 3 internal uses in https://www.grep.app/search?q=on_before_accelerator_backend_setup
Users can implement the setup hook instead.
Additional context
This hook was originally added in #5377
Part of #7740
cc @justusschock @awaelchli @akihironitta @rohitgr7 @tchaton @carmocca @Borda @ninginthecloud @daniellepintz
ananthsub
Metadata
Metadata
Assignees
Labels
deprecationIncludes a deprecationIncludes a deprecationgood first issueGood for newcomersGood for newcomershelp wantedOpen to be worked onOpen to be worked onhooksRelated to the hooks APIRelated to the hooks APIpriority: 0High priority taskHigh priority taskrefactor