Skip to content

use_amp is broken in 0.7.0 #1143

@rmrao

Description

@rmrao

I see that use_amp is deprecated but since the Trainer still accepts it as an argument, I believe this is still a bug.

The issue is that the hook that deals with this specifically checks if trainer.precision == 16. However, the Trainer does not set precision = 16 if use_amp = True.

Proposed solution:

if use_amp is passed in, set precision = 16 and raise a deprecation warning.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions