-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Closed
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomerspriority: 0High priority taskHigh priority task
Milestone
Description
I see that use_amp is deprecated but since the Trainer still accepts it as an argument, I believe this is still a bug.
The issue is that the hook that deals with this specifically checks if trainer.precision == 16. However, the Trainer does not set precision = 16 if use_amp = True.
Proposed solution:
if use_amp is passed in, set precision = 16 and raise a deprecation warning.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomerspriority: 0High priority taskHigh priority task