Skip to content

Commit 8034919

Browse files
authored
Remove deprecated TestTubeLogger (#12859)
* remove deprecated test_tube logger * remove testube from logger __init__ * remove relevant testtube tests * update CHANGELOG with removal of deprecated `TestTubeLogger`
1 parent 70309d8 commit 8034919

File tree

10 files changed

+8
-296
lines changed

10 files changed

+8
-296
lines changed

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ pip-wheel-metadata/
77
lightning_logs/
88
.vscode/
99

10-
# Test-tube
11-
test_tube_*/
12-
1310
# Documentations
1411
docs/source/api
1512
docs/source/*.md

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
7070

7171
### Removed
7272

73+
- Removed the deprecated `TestTubeLogger` ([#12859](https://github.com/PyTorchLightning/pytorch-lightning/pull/12859))
74+
75+
7376
- Removed the deprecated `pytorch_lightning.core.memory.LayerSummary` and `pytorch_lightning.core.memory.ModelSummary` ([#12593](https://github.com/PyTorchLightning/pytorch-lightning/pull/12593))
7477

7578

docs/source/api_references.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ loggers
9393
mlflow
9494
neptune
9595
tensorboard
96-
test_tube
9796
wandb
9897

9998
loops

docs/source/common/evaluation_intermediate.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ To run the test set on a pre-trained model, use this method.
8282
8383
model = MyLightningModule.load_from_checkpoint(
8484
checkpoint_path="/path/to/pytorch_checkpoint.ckpt",
85-
hparams_file="/path/to/test_tube/experiment/version/hparams.yaml",
85+
hparams_file="/path/to/experiment/version/hparams.yaml",
8686
map_location=None,
8787
)
8888

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ module = [
6161
"pytorch_lightning.loggers.mlflow",
6262
"pytorch_lightning.loggers.neptune",
6363
"pytorch_lightning.loggers.tensorboard",
64-
"pytorch_lightning.loggers.test_tube",
6564
"pytorch_lightning.loggers.wandb",
6665
"pytorch_lightning.loops.epoch.training_epoch_loop",
6766
"pytorch_lightning.strategies.ddp",

pytorch_lightning/loggers/__init__.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
from pytorch_lightning.loggers.comet import _COMET_AVAILABLE, CometLogger # noqa: F401
2626
from pytorch_lightning.loggers.mlflow import _MLFLOW_AVAILABLE, MLFlowLogger # noqa: F401
2727
from pytorch_lightning.loggers.neptune import _NEPTUNE_AVAILABLE, NeptuneLogger # noqa: F401
28-
from pytorch_lightning.loggers.test_tube import _TESTTUBE_AVAILABLE, TestTubeLogger # noqa: F401
2928
from pytorch_lightning.loggers.wandb import WandbLogger # noqa: F401
3029
from pytorch_lightning.utilities.imports import _WANDB_AVAILABLE
3130

@@ -40,8 +39,5 @@
4039
if _NEPTUNE_AVAILABLE:
4140
__all__.append("NeptuneLogger")
4241

43-
if _TESTTUBE_AVAILABLE:
44-
__all__.append("TestTubeLogger")
45-
4642
if _WANDB_AVAILABLE:
4743
__all__.append("WandbLogger")

pytorch_lightning/loggers/test_tube.py

Lines changed: 0 additions & 251 deletions
This file was deleted.

requirements/loggers.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@
22
neptune-client>=0.10.0
33
comet-ml>=3.1.12
44
mlflow>=1.0.0
5-
test_tube>=0.7.5
65
wandb>=0.8.21

tests/deprecated_api/test_remove_1-7.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
from pytorch_lightning import Callback, Trainer
2424
from pytorch_lightning.callbacks.lr_monitor import LearningRateMonitor
25-
from pytorch_lightning.loggers import LoggerCollection, TestTubeLogger
25+
from pytorch_lightning.loggers import LoggerCollection
2626
from pytorch_lightning.overrides.distributed import IndexBatchSamplerWrapper
2727
from pytorch_lightning.plugins.environments import (
2828
KubeflowEnvironment,
@@ -84,12 +84,6 @@ def _run(model, task="fit"):
8484
_run(model, "predict")
8585

8686

87-
@mock.patch("pytorch_lightning.loggers.test_tube.Experiment")
88-
def test_v1_7_0_test_tube_logger(_, tmpdir):
89-
with pytest.deprecated_call(match="The TestTubeLogger is deprecated since v1.5 and will be removed in v1.7"):
90-
_ = TestTubeLogger(tmpdir)
91-
92-
9387
def test_v1_7_0_on_interrupt(tmpdir):
9488
class HandleInterruptCallback(Callback):
9589
def on_keyboard_interrupt(self, trainer, pl_module):

0 commit comments

Comments
 (0)