Apply suggestions from code review

Co-authored-by: Rohit Gupta <[email protected]>

Author: ddrevicky

pytorch_lightning/trainer/connectors/profiler_connector.py

@@ -35,6 +35,6 @@ def on_trainer_init(self, profiler: Union[BaseProfiler, bool, str]):
         elif profiler == "advanced":
             profiler = AdvancedProfiler()
         elif isinstance(profiler, str):
-            raise ValueError('when passing string value for the `profiler` parameter of'
-                             ' `Trainer`, it can only be `simple` or `advanced`')
+            raise ValueError("When passing string value for the `profiler` parameter of"
+                             " `Trainer`, it can only be 'simple' or 'advanced'")
         self.trainer.profiler = profiler or PassThroughProfiler()

tests/test_deprecated.py

@@ -28,13 +28,13 @@ def test_tbd_remove_in_v0_11_0_trainer_gpu():
         gpu_usage = GpuUsageLogger()
 
 
-@pytest.mark.parametrize(['input_arg', 'expected'], [
+@pytest.mark.parametrize(['profiler', 'expected'], [
     (True, SimpleProfiler),
     (False, PassThroughProfiler),
 ])
-def test_trainer_profiler_remove_in_v0_11_0_trainer(input_arg, expected):
+def test_trainer_profiler_remove_in_v0_11_0_trainer(profiler, expected):
     with pytest.deprecated_call(match='will be removed in v0.11.0'):
-        trainer = Trainer(profiler=input_arg)
+        trainer = Trainer(profiler=profiler)
         assert isinstance(trainer.profiler, expected)
 
 

tests/trainer/test_trainer.py

@@ -1196,6 +1196,6 @@ def test_trainer_profiler_correct_args(input_arg, expected):
 
 
 def test_trainer_profiler_incorrect_str_arg():
-    with pytest.raises(ValueError, match=r'when passing string value for the `profiler` parameter of '
-                       '`Trainer`, it can only be `simple` or `advanced`'):
+    with pytest.raises(ValueError, match=r"When passing string value for the `profiler` parameter of"
+                       "` Trainer`, it can only be 'simple' or 'advanced'"):
         Trainer(profiler="unknown_profiler")