fixup! Add deprecation tests and move deprecated tests

Author: ddrevicky

tests/test_deprecated.py

@@ -28,13 +28,13 @@ def test_tbd_remove_in_v0_11_0_trainer_gpu():
         gpu_usage = GpuUsageLogger()
 
 
-@pytest.mark.parametrize(['input', 'expected'], [
+@pytest.mark.parametrize(['input_arg', 'expected'], [
     (True, SimpleProfiler),
     (False, PassThroughProfiler),
 ])
-def test_trainer_profiler_remove_in_v0_11_0_trainer(input, expected):
+def test_trainer_profiler_remove_in_v0_11_0_trainer(input_arg, expected):
     with pytest.deprecated_call(match='will be removed in v0.11.0'):
-        trainer = Trainer(profiler=input)
+        trainer = Trainer(profiler=input_arg)
         assert isinstance(trainer.profiler, expected)
 
 

tests/trainer/test_trainer.py

@@ -1182,15 +1182,15 @@ def test_row_log_interval(log_metrics_mock, tmpdir, train_batches, max_steps, lo
     log_metrics_mock.assert_has_calls(expected_calls)
 
 
-@pytest.mark.parametrize(['input', 'expected'], [
+@pytest.mark.parametrize(['input_arg', 'expected'], [
     (None, PassThroughProfiler),
     (SimpleProfiler(), SimpleProfiler),
     (AdvancedProfiler(), AdvancedProfiler),
     ('simple', SimpleProfiler),
     ('advanced', AdvancedProfiler),
 ])
-def test_trainer_profiler_correct_args(input, expected):
-    kwargs = {'profiler': input} if input is not None else {}
+def test_trainer_profiler_correct_args(input_arg, expected):
+    kwargs = {'profiler': input_arg} if input_arg is not None else {}
     trainer = Trainer(**kwargs)
     assert isinstance(trainer.profiler, expected)